Migrate activity_api_batch_reset_test to testcore.NewEnv#9676
Merged
chaptersix merged 2 commits intotemporalio:mainfrom Mar 26, 2026
Merged
Migrate activity_api_batch_reset_test to testcore.NewEnv#9676chaptersix merged 2 commits intotemporalio:mainfrom
chaptersix merged 2 commits intotemporalio:mainfrom
Conversation
…ttern Replace suite-based test structure with t.Run subtests using testcore.NewEnv, consistent with the ongoing test migration effort.
spkane31
approved these changes
Mar 26, 2026
chaptersix
added a commit
to chaptersix/temporal
that referenced
this pull request
Apr 2, 2026
…9676) ## Summary - Migrate `activity_api_batch_reset_test.go` from suite-based pattern (`FunctionalTestBase` + `suite.Run`) to `testcore.NewEnv` with `t.Run` subtests - Convert `createWorkflow` receiver method to standalone `createBatchResetWorkflow` function - Replace `s.TaskQueue()` with `s.WorkerTaskQueue()` ## Test plan - [x] `go build -tags disable_grpc_modules,test_dep ./tests/...` - [x] `go test -tags disable_grpc_modules,test_dep -timeout 5m -run TestActivityApiBatchResetClientTestSuite ./tests/...` - [x] `make lint`
chaptersix
added a commit
to chaptersix/temporal
that referenced
this pull request
Apr 2, 2026
…9676) ## Summary - Migrate `activity_api_batch_reset_test.go` from suite-based pattern (`FunctionalTestBase` + `suite.Run`) to `testcore.NewEnv` with `t.Run` subtests - Convert `createWorkflow` receiver method to standalone `createBatchResetWorkflow` function - Replace `s.TaskQueue()` with `s.WorkerTaskQueue()` ## Test plan - [x] `go build -tags disable_grpc_modules,test_dep ./tests/...` - [x] `go test -tags disable_grpc_modules,test_dep -timeout 5m -run TestActivityApiBatchResetClientTestSuite ./tests/...` - [x] `make lint`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
activity_api_batch_reset_test.gofrom suite-based pattern (FunctionalTestBase+suite.Run) totestcore.NewEnvwitht.RunsubtestscreateWorkflowreceiver method to standalonecreateBatchResetWorkflowfunctions.TaskQueue()withs.WorkerTaskQueue()Test plan
go build -tags disable_grpc_modules,test_dep ./tests/...go test -tags disable_grpc_modules,test_dep -timeout 5m -run TestActivityApiBatchResetClientTestSuite ./tests/...make lint